Conversation
* refactor: add router unit tests * fix: allow preserve build format in router * test: remove routing integration fixtures * Avoid an extra loop * PR comments * Full refactor * fixes breaking test * fix tests failing * fix tests again * Fix router match with base-stripped SSR paths * fix shiki lazy language test * Redirect base path in router match * Collapse double-slash redirects in router * Honor pageExtensions in parseRoute * Move buildOutput defaulting to callers * Ensure default 404 before router init * Use internal fileExtension helper in parseRoute * Use at(-1) for last route segment * Document extension stripping in parseRoute * Replace routing README with JSDoc * Broaden router redirect status type * Return base variable in normalizeBase * Return input value for root slash * Reuse path helpers in router * Type buildFormat from AstroConfig * Add JSDoc to routing test helpers * Fix prerender utils import paths * fix int * Add comment explaining why the routes are sorted
* fix: include slot scripts in server island response Components passed as slots to server:defer components had their scripts silently dropped because renderSlotToString separates HTML content from render instructions, and only the HTML was serialized into the island payload via content.toString(). This appends script instructions to the slot HTML before encryption, so the island response includes the scripts needed for interactivity. This may result in duplicate script injection when the same component is also used statically on the page. Deduplication is not feasible here due to the concurrent BufferedRenderer model — renderedScripts is not yet populated at the time island payloads are constructed. * add changeset * fix: cast SlotString for type safety * use Array.isArray guard for defensive type safety * test: verify slotted component scripts in server island response * Update .changeset/server-island-slot-scripts.md Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> * improved type import --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…are Workers (#15648) * fix: Fix integration test failure for `<Code />` component on Cloudflare Workers * add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )